← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 4401: MDEV-7448 - mtr may leave stale mysqld in lp:maria/5.5

 

Hi, Sergey!

On Jan 14, Sergey Vojtovich wrote:
> ------------------------------------------------------------
> revno: 4401
> revision-id: svoj@xxxxxxxxxxx-20150114135038-jss2vvpkhihysfmj
> parent: sergii@xxxxxxxxx-20150110130746-xlrofqddt4j8xkw6
> committer: Sergey Vojtovich <svoj@xxxxxxxxxxx>
> branch nick: 5.5
> timestamp: Wed 2015-01-14 17:50:38 +0400
> message:
>   MDEV-7448 - mtr may leave stale mysqld
>   
>   Let mtr handle SIGHUP the same way as SIGINT. This solves stale mysqld processes
>   left after broken/closed ssh connection.

Looks ok. But please make sure that all tests pass before pushing it.

mysqld uses SIGHUP to print various information to the error log.
If there's a test that actually tests that by sending SIGHUP - your
change might've broken it.

Regards,
Sergei