← Back to team overview

maria-developers team mailing list archive

Comments/thoughts on patch

 

Hi Kristian,

I wrote attached patch (so that i would understand what code actually does)
and found myself while refactoring also doing a change, namely that
i removed the check for server_id in a couple of places.

it still passes all tests...
could you comment on this, or write(outline) a testcase that fails with my
patch.

i think functionality that i might have removed would be if you write have
2 mysqld M1 & M2
and your replicate both way...and you *don't* use domain_id...and you write
concurrently on both
mysqld (but maybe disjoint data ??).

feedback/comments appreciated.

/Jonas

ps. patch applies to f4f37533a09b9776e8d5ac3f3a27957f553c9043

Attachment: patch
Description: Binary data


Follow ups