maria-developers team mailing list archive
Mailing list archive
Re: Comments/thoughts on patch
update: just tested your new testcase with my patch...and it passes...
i.e the test does not expose any problem in my patch
On Thu, Mar 5, 2015 at 1:22 PM, Jonas Oreland <jonaso@xxxxxxxxxx> wrote:
> great thx! (was on my TODO...but got stuck on other things today).
> I'll write a new patch, that passes this test too
> On Thu, Mar 5, 2015 at 9:54 AM, Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx
> > wrote:
>> Jonas Oreland <jonaso@xxxxxxxxxx> writes:
>> > I wrote attached patch (so that i would understand what code actually
>> > and found myself while refactoring also doing a change, namely that
>> > i removed the check for server_id in a couple of places.
>> > it still passes all tests...
>> It is somewhat surprising (and bad) that there were no test cases that
>> So I pushed a suitable test case:
>> Maybe it can help you...
>> - Kristian.