maria-developers team mailing list archive
Mailing list archive
Re: [Commits] 52c3687: MDEV-8241: Debug build on Windows is broken: error LNK2019: unresolved external symbol pthread_detach referenced in function ma_checkpoint_init
On 29.05.15 17:35, Sergei Golubchik wrote:
On May 28, sanja@xxxxxxxxxxx wrote:
committer: Oleksandr Byelkin
branch nick: server
timestamp: 2015-05-28 07:59:57 +0200
MDEV-8241: Debug build on Windows is broken: error LNK2019: unresolved external symbol pthread_detach referenced in function ma_checkpoint_init
pthread_detach() replaced with pthread_detach_this_thread()
pthread_detach_this_thread() definition fixed
diff --git a/storage/maria/ma_checkpoint.c b/storage/maria/ma_checkpoint.c
index 2268ca6..36b729e 100644
@@ -340,7 +340,6 @@ int ma_checkpoint_init(ulong interval)
/* thread lives, will have to be killed */
@@ -574,6 +573,8 @@ pthread_handler_t ma_checkpoint_background(void *arg)
for(;;) /* iterations of checkpoints and dirty page flushing */
How does that help? What was wrong with pthread_detach()?
pthread_detach() is not a part of our "OS independent suite" (see file
where I was fixing pthread_detach_this_thread()).
First I added pthread_detach(), then decided to fix what we already have
and use it.