← Back to team overview

maria-developers team mailing list archive

Re: [Commits] 2e08ec2: MDEV-7956 - handler::rebind_psi() takes 0.07% in OLTP RO

 

Hi, Sergey!

On Jun 17, svoj@xxxxxxxxxxx wrote:
> revision-id: 2e08ec24623e0b3d3db02333e16658dcfaa0535c
> parent(s): b776f8d3a8afff55d5f8208da7bdfce9aa33eb39
> committer: Sergey Vojtovich
> branch nick: mariadb
> timestamp: 2015-06-17 13:09:22 +0400
> message:
> 
> MDEV-7956 - handler::rebind_psi() takes 0.07% in OLTP RO
> 
> Do not call handler::rebind_psi() and handler::unbind_psi() when performance
> schema is compiled out.

I don't particularly like it, you're just avoding an empty virtual
function call, and that in a configuration (no P_S) which no our
binaries use.

But you can push it if you want.

Regards,
Sergei


Follow ups