maria-developers team mailing list archive

[Sergey Vojtovich <svoj@xxxxxxxxxxx>]

Hi Sergei,

On Thu, Jun 18, 2015 at 12:06:30PM +0200, Sergei Golubchik wrote:
> Hi, Sergey!
> 
> On Jun 17, svoj@xxxxxxxxxxx wrote:
> > revision-id: 2e08ec24623e0b3d3db02333e16658dcfaa0535c
> > parent(s): b776f8d3a8afff55d5f8208da7bdfce9aa33eb39
> > committer: Sergey Vojtovich
> > branch nick: mariadb
> > timestamp: 2015-06-17 13:09:22 +0400
> > message:
> > 
> > MDEV-7956 - handler::rebind_psi() takes 0.07% in OLTP RO
> > 
> > Do not call handler::rebind_psi() and handler::unbind_psi() when performance
> > schema is compiled out.
> 
> I don't particularly like it, you're just avoding an empty virtual
> function call, and that in a configuration (no P_S) which no our
> binaries use.
> 
> But you can push it if you want.
Yes, I believe it is worthy: almost 0.1% for no good reason. There's at least
one indication that people compile out performance schema:
https://mariadb.atlassian.net/browse/MDEV-5220

I can just surround these calls with ifdef-s if you like. This way we'll keep
PFS code completely intact.

Thanks,
Sergey