← Back to team overview

maria-developers team mailing list archive

Re: [Commits] ee656a4: MDEV-7846: postreview fix


On 05.08.15 12:47, Sergei Golubchik wrote:
Hi, Sanja!

I have no idea how this postreview fix relates to any of my review
As we already figured out it relates.
  Let me repeat them again:

1. Add comments
Comments added
2. Add a test case with row items
Added as separate bug MDEV-8902 (investigation showed that it has its own ways to be fixed)
3. In your test case - if you remove GROUP BY you get a crash again.
    This might be a different bug, though.
it is Semi-join conversion artificial name resolution context bug in case of outer field used MDEV-8833

So all postreview is here:

revision-id: 74f1ae282f9395dd704f94c5f21acbee35de898c (mariadb-5.5.45-15-g74f1ae2)
parent(s): e3ad2f4e545101bd1f48001225df03bab6865e5c
committer: Oleksandr Byelkin
timestamp: 2015-10-06 12:07:46 +0200

MDEV-7846: postreview fix