maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Sanja!

I have no idea how this postreview fix relates to any of my review
comments. Let me repeat them again:

1. Add comments
2. Add a test case with row items
3. In your test case - if you remove GROUP BY you get a crash again.
   This might be a different bug, though.

On Aug 05, sanja@xxxxxxxxxxx wrote:
> revision-id: ee656a4aabb5ebbe973b7e4c99be83eb5dc8c0ce
> parent(s): 9f8a458fb2d07298810bb5d9824ce728017bfb32
> committer: Oleksandr Byelkin
> branch nick: server
> timestamp: 2015-08-05 11:57:35 +0200
> message:
> 
> MDEV-7846: postreview fix
> 
> diff --git a/sql/item_cmpfunc.cc b/sql/item_cmpfunc.cc
> index 29fff8e..e96d1bc 100644
> --- a/sql/item_cmpfunc.cc
> +++ b/sql/item_cmpfunc.cc
> @@ -1455,12 +1455,13 @@ bool Item_in_optimizer::fix_left(THD *thd, Item **ref)
>         next execution we need to copy args[1]->left_expr again.
>      */
>      ref0= &(((Item_in_subselect *)args[1])->left_expr);
> +    args[0]= ((Item_in_subselect *)args[1])->left_expr;
>    }
>    if ((!(*ref0)->fixed && (*ref0)->fix_fields(thd, ref0)) ||
>        (!cache && !(cache= Item_cache::get_cache(*ref0))))
>      DBUG_RETURN(1);
>    if (args[0] != (*ref0))
> -    current_thd->change_item_tree(args, (*ref0));
> +    args[0]= (*ref0);
>    DBUG_PRINT("info", ("actual fix fields"));

Regards,
Sergei