← Back to team overview

maria-developers team mailing list archive

Re: [Commits] 732d45e: MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in many


Hi Sergei,

On Tue, Dec 15, 2015 at 10:49:37PM +0100, Sergei Golubchik wrote:
> Hi, Sergey!
> On Dec 14, Sergey Vojtovich wrote:
> > revision-id: 732d45e93b81a104e3f3931e4908e22167a54622 (mariadb-10.0.22-57-g732d45e)
> > parent(s): 3e206a518dec400e084451165f633b78eb2e7fee
> > committer: Sergey Vojtovich
> > timestamp: 2015-12-14 15:27:09 +0400
> > message:
> > 
> > MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in many
> >             of the plugins
> > 
> > Fixed exit/_exit calls from libdaemon_example.so, libmysqlclient.so,
> > libmysqlclient_r.so, libmysqld.so.
> > 
> > Note: this is just rough prototype, not to be pushed. libmysqld.so still has
> > a bunch of exit/_exit calls from InnoDB.

> Are you sure we want to fix that at all?
Definitely daemon_example. The rest is nice to have (e.g. I wouldn't want my
app to exit if embedded gets --print-defaults).

But the fix should be different: change of abort to exit makes little sense.
Either we should pass through error code, or disable code which is never
executed by embedded/libmysqlclient with ifdefs.

> And if yes - is it something we need to bother fixing now?
The right fix as described above may become complex, so I'd rather postpone it
for 10.2. But Debian is suffering from this now with 10.0.

I don't know.

> How comes it's "critical"?
I think the reason behind "critical" is our willing to please Debian.

If you don't mind I'll push daemon_example part of this fix and remove
my_abort_hook: one line less in lintian report is a progress still.


Follow ups