maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Nirbhay!

On Dec 07, Nirbhay Choubey wrote:
> revision-id: 0b0d34138300b891ccbec58e01f3ab5bebe24d71
> parent(s): 3c0e9d31b3e6494931deb09f5c93b05a96df8471
> committer: Nirbhay Choubey
> branch nick: 10.1.b9044
> timestamp: 2015-12-07 14:01:52 -0500
> message:
> 
> MDEV-9044 : Binlog corruption in Galera
> 
> While refreshing the IO_CACHE, do not update its parameters (read_pos,
> read_end & pos_in_file) if there is nothing left to read.

I'm sorry, but I don't understand the fix. Why should parameters be not
updated? If there's nothing left to read, the cache is marked as empty,
that seems to be correct.

> diff --git a/mysys/mf_iocache.c b/mysys/mf_iocache.c
> index 28e5e72..db8d0b5 100644
> --- a/mysys/mf_iocache.c
> +++ b/mysys/mf_iocache.c
> @@ -663,7 +663,11 @@ int _my_b_cache_read(IO_CACHE *info, uchar *Buffer, size_t Count)
>        info->error= (int) left_length;
>        DBUG_RETURN(1);
>      }
> -    length=0;				/* Didn't read any chars */
> +    else
> +    {
> +      info->error= 0;
> +      DBUG_RETURN(0);                           /* EOF */
> +    }
>    }

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx
-- 
Vote for my Percona Live 2016 talks:
https://www.percona.com/live/data-performance-conference-2016/sessions/mariadb-connectors-fast-and-smart-new-protocol-optimizations#community-voting
https://www.percona.com/live/data-performance-conference-2016/sessions/mariadb-101-security-validation-authentication-encryption#community-voting