maria-developers team mailing list archive

Thread
Date

Re: Please review MDEV-10051 Fix subselect to return a syntax error instead of "Incorrect usage of UNION and LIMIT"

To: Alexander Barkov <bar@xxxxxxxxxxx>
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Wed, 11 May 2016 12:20:41 +0200
Cc: maria-developers <maria-developers@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <5731E9CA.3080706@mariadb.org>
User-agent: Mutt/1.5.24 (2015-08-30)

Hi, Alexander!

On May 10, Alexander Barkov wrote:
> Hello Sergei,
> 
> Please review the next step for
> MDEV-8909 union parser cleanup
> 
> Now it's MDEV-10051, and it fixes subselects.
> 
> Note, I decided to fix derived tables in a separate patch later.
> So there will be one more patch blocking MDEV-8909.

Sorry, I cannot review that. It uses your grammar changes from a
previous patch and I cannot keep all previous patches in my head when
I'm reviewing the next one. Is this your MDEV-8909 tree on github?

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx

References

Please review MDEV-10051 Fix subselect to return a syntax error instead of "Incorrect usage of UNION and LIMIT"
From: Alexander Barkov, 2016-05-10