maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Alexander!

On Jun 27, Alexander Barkov wrote:

> commit 1509b44ed12320cc037520cc6eeeca2a0a17fc65
> Author: Alexander Barkov <bar@xxxxxxxxxxx>
> Date:   Mon Jun 27 11:45:40 2016 +0400
> 
>     MDEV-10236 Where expression with NOT function gives incorrect result
>     Item_cache::is_null() erroneously returned null_value in
>     non-cached state. Now Item_cache::is_null() uses has_value(),
>     which caches the value if necessarily, similar to what other value methods do
>     (e.g. val_int, val_real, etc).

Always leave an empty line between the commit "subject" (the first line)
and commit comment "body" (everything else). For example, if you'd used
"git commit" and EDITOR=vim, it would've highlighted the second line
red, because the second line must be empty. Github also splits the
comment into the "subject" and a "body". Best to follow this convention.

After that ok to push, thanks!

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx