maria-developers team mailing list archive

Thread
Date

Re: [Commits] 3b6eff5: MDEV-8569 build_table_filename() doesn't support temporary tables.

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Tue, 12 Jul 2016 18:21:32 +0200
Cc: holyfoot@xxxxxxxxxxx
In-reply-to: <20160712122056.24613140DC6@nebo.localdomain>
User-agent: Mutt/1.5.24 (2015-08-30)

Hi, Alexey!

On Jul 12, Alexey Botchkov wrote:
> revision-id: 3b6eff5954c70a5795e1162b381a1b88af390764 (mariadb-10.0.26-8-g3b6eff5)
> parent(s): 3e8ae6ef4f08937332e6ad317f37a9c0c9a717d3
> committer: Alexey Botchkov
> timestamp: 2016-07-12 16:19:26 +0400
> message:
> 
> MDEV-8569 build_table_filename() doesn't support temporary tables.
> 
> Temporary tables support added for RENAME and ALTER TABLE.

Ok, so instead of fixing build_table_filename, you've fixed RENAME and
ALTER. Did you verify that all other build_table_filename() uses are
safe? Ok to push, if yes.

Still, it's rather fragile code, any idea how to improve it?
Is it possible to add an assert to build_table_filename() to
catch incorrect usage? Can build_table_filename() be changed somehow to
make incorrect usage impossible (e.g. passing TABLE as an argument)?

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx