← Back to team overview

maria-developers team mailing list archive

Missing tests for MDEV-10057 and MDEV-10058

 

Hello Sergey and Igor,

You recently closed MDEV-10057 and MDEV-10058, but forgot to add tests.

- MDEV-10057 does not have tests at all.

- MDEV-10058 has only the parser related test,
but does not have this test:

EXPLAIN SELECT * FROM (WITH a AS (SELECT * FROM t1) SELECT * FROM t2 NATURAL JOIN t3) AS d1;


Can you please add the missing tests?


Adding patches without tests makes merging painful.
You never know if a merge (especially an automatic one)
breaks something.

Thanks!


Follow ups