maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Jan!

On Oct 10, Jan Lindström wrote:

> parent(s): a6f032af5778018051d41fc8ba7e9c983b4b7fbf
> author: Jan Lindström
> committer: Jan Lindström
> timestamp: 2016-10-10 12:34:06 +0300
> message:
> 
> MDEV-11005: Incorrect error message when using ONLINE alter table with GIS
> 
> Fix incorrect error message on ONLINE alter table with GIS indexes and
> add rtree page type to page type check.
> 
> diff --git a/sql/share/errmsg-utf8.txt b/sql/share/errmsg-utf8.txt
> index d42611b..2892342 100644
> --- a/sql/share/errmsg-utf8.txt
> +++ b/sql/share/errmsg-utf8.txt
> @@ -6861,6 +6861,9 @@ ER_ALTER_OPERATION_NOT_SUPPORTED_REASON_CHANGE_FTS
>  ER_ALTER_OPERATION_NOT_SUPPORTED_REASON_FTS
>    eng "Fulltext index creation requires a lock"
>  
> +ER_ALTER_OPERATION_NOT_SUPPORTED_REASON_GIS
> +  eng "Do not support online operation on table with GIS index"
> +

No, this is absolutely not possible in 10.2.

ER_SQL_SLAVE_SKIP_COUNTER_NOT_SETTABLE_IN_GTID_MODE, the next error
message, was added in 10.0. If you add a new error message here, then
the error number for ER_SQL_SLAVE_SKIP_COUNTER_NOT_SETTABLE_IN_GTID_MODE
will change. But 10.0 is GA, and error numbers cannot be changed in GA
versions.

You can add your new ER_ALTER_OPERATION_NOT_SUPPORTED_REASON_GIS
after ER_CANNOT_DISCARD_TEMPORARY_TABLE, or, preferrably, copy all MySQL
errors from 3000 and up to ER_ALTER_OPERATION_NOT_SUPPORTED_REASON_GIS.
This will ensure that ER_ALTER_OPERATION_NOT_SUPPORTED_REASON_GIS will
have the same number in MariaDB and in MySQL.

>  ER_SQL_SLAVE_SKIP_COUNTER_NOT_SETTABLE_IN_GTID_MODE
>    eng "sql_slave_skip_counter can not be set when the server is running with GTID_MODE = ON. Instead, for each transaction that you want to skip, generate an empty transaction with the same GTID as the transaction"

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx