maria-developers team mailing list archive
Mailing list archive
Re: 1579140: MDEV-11005: Incorrect error message when using ONLINE alter table with GIS
Sergei Golubchik <serg@xxxxxxxxxxx> writes:
> ER_SQL_SLAVE_SKIP_COUNTER_NOT_SETTABLE_IN_GTID_MODE, the next error
> message, was added in 10.0. If you add a new error message here, then
> the error number for ER_SQL_SLAVE_SKIP_COUNTER_NOT_SETTABLE_IN_GTID_MODE
> will change. But 10.0 is GA, and error numbers cannot be changed in GA
As it happens, ER_SQL_SLAVE_SKIP_COUNTER_NOT_SETTABLE_IN_GTID_MODE is no
longer used anywhere, it was only used in early versions of 10.0.
> You can add your new ER_ALTER_OPERATION_NOT_SUPPORTED_REASON_GIS
> after ER_CANNOT_DISCARD_TEMPORARY_TABLE, or, preferrably, copy all MySQL
> errors from 3000 and up to ER_ALTER_OPERATION_NOT_SUPPORTED_REASON_GIS.
> This will ensure that ER_ALTER_OPERATION_NOT_SUPPORTED_REASON_GIS will
> have the same number in MariaDB and in MySQL.
But I still agree with Serg here.