← Back to team overview

maria-developers team mailing list archive

Re: bb-10.2-compatibility

 

Hi Alexander,
Here is the patch that corrects the line number of errors.
Only tests from test suite for oracle seems to be affected.

Row number are correct when test is recorded with  "mysql-test-run.pl -record",  but wrong with mysql or mysqltest (I don't understand why !)

Regard,
Jérôme.

> -----Message d'origine-----
> De : Alexander Barkov [mailto:bar@xxxxxxxxxxx]
> Envoyé : mardi 28 mars 2017 07:42
> À : jerome brauge
> Objet : Re: bb-10.2-compatibility
> 
> Hi Jerome,
> 
> 
> On 03/28/2017 08:45 AM, jerome brauge wrote:
> > Alexander,
> > Due to this ,  when i record test for sp-cursor-rowtype.test, I have:
> >
> > Warning	1265	Data truncated for column 'b' at row 2
> >
> > instead of
> >
> > Warning	1265	Data truncated for column 'b' at row 1
> >
> > for test
> > # Fetching a cursor into a cursor%ROWTYPE variable, with truncation
> >
> > I do a test with an older project to see if it's work better.
> 
> It's Ok to record with a wrong "at row XXX" for now, as this bug is not specific
> to bb-10.2-compatibility.
> 
> When this problem is fixed in parent branches (10.0, 10.1, 10.2), we'll merge
> into bb-10.2-compatibility and fix wrong "at row XXX"
> results.
> 
> 
> Btw, it's very likely that bb-10.2-compatibility will be merged to 10.3 soon, in
> the beginning of April.
> 
> 
> 
> >
> > Jérôme.
> >
> >> -----Message d'origine-----
> >> De : Alexander Barkov [mailto:bar@xxxxxxxxxxx] Envoyé : mardi 28 mars
> >> 2017 06:10 À : jerome brauge Objet : Re: bb-10.2-compatibility
> >>
> >> Hello Jerome,
> >>
> >> On 03/28/2017 12:03 AM, jerome brauge wrote:
> >>> Hello Alexander,
> >>> Now that my linux build is ok, I have something strange with
> >>> warnings on cursors (detected in  sp-cursor-rowtype.test)
> >>>
> >>> The following code
> >>>
> >>> set sql_mode=oracle;
> >>> use test
> >>> CREATE or replace TABLE wjbt1 (a INT, b VARCHAR(10)); CREATE or
> >>> replace TABLE wjbt2 (a INT, b INT); INSERT INTO wjbt1 VALUES
> >>> (10,'11x'); INSERT INTO wjbt1 VALUES (10,'12x'); delimiter $$ CREATE
> >>> or replace PROCEDURE pwjb1() AS CURSOR cur1 IS SELECT b FROM
> wjbt1;
> >>> BEGIN DECLARE res int; BEGIN OPEN cur1; FETCH cur1 INTO res; FETCH
> >>> cur1 INTO res; CLOSE cur1; END; END; $$ delimiter ; call pwjb1();
> >>> show warnings;
> >>>
> >>> returns:
> >>> +---------+------+------------------------------------------+
> >>> | Level   | Code | Message                                  |
> >>> +---------+------+------------------------------------------+
> >>> | Warning | 1265 | Data truncated for column 'res' at row 3 |
> >>> | Warning
> >>> | | 1265 | Data truncated for column 'res' at row 3 |
> >>> +---------+------+------------------------------------------+
> >>>
> >>> I done this test on Linux and Windows with the same behavious.
> >>> I don't understand why. Do you have an idea ?
> >>
> >>
> >> Truncation seems to be correct,
> >> because the procedure converts '11x' and '12x' to INT.
> >>
> >> But 'at row 3' seems to be wrong.
> >>
> >> I reported the problem as:
> >>
> >> https://jira.mariadb.org/browse/MDEV-12377
> >>
> >> Looks like an old bug. MariaDB-10.0 exposes the same behavior.
> >>
> >>
> >>>
> >>> Regards,
> >>> Jérôme.
> >>>

Attachment: 0001-Correct-yyline-no-when-sql_mode-include-IGNORE_SPACE.PATCH
Description: 0001-Correct-yyline-no-when-sql_mode-include-IGNORE_SPACE.PATCH


Follow ups

References