← Back to team overview

maria-developers team mailing list archive

Re: commit_checkpoint_request() vs. thd_get_durability_property() (in relation to MDEV-11937)



Thank you for your analysis. I suggest that we remove the unused
declarations and code as soon as possible. Would you do that already under

I think that future code merges from MySQL should be based on individual
commits rather than snapshots. For merging the changes from 5.7.14 to
5.7.18, I already did this, and I rewrote or omitted some commits; see

One particular problem with snapshots is that changes or additions to test
files were often omitted. When merging changes commit by commit ("git
format-patch" followed by "git am"), some manual work is needed to import
the affected test files. The Oracle policy should be to only withhold test
files for security bugs; we should take full advantage of the public tests.

Best regards,


On Mon, Aug 7, 2017 at 2:25 PM, Jan Lindström <jan.lindstrom@xxxxxxxxxxx>

> Hi,
> On Mon, Aug 7, 2017 at 2:09 PM, Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx
> > wrote:
>> The problem is that somehow the thd_get_durability_property() function was
>> introduced into MariaDB code, but it is completely non-functional. So now
>> there is code in InnoDB, TokuDB and RocksDB that calls this function and
>> does not work correctly. This lead to performance regression due to extra
>> fsync() calls.
> This function was introduced while I was doing InnoDB 5.7.9 merge, this
> was huge
> merge but in my understanding all server changes i.e. also storage API
> changes were
> reviewed. But, as patch was significant there was error. That function
> should not be introduced.
>> Or was the intention to eventually replace the whole MariaDB binlog group
>> commit implementation with the MySQL one, to make MariaDB less divergent?
>> This would require a number of changes to MariaDB binlog and replication.
> No this was not the intention.
> R: Jan
> _______________________________________________
> Mailing list: https://launchpad.net/~maria-developers
> Post to     : maria-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~maria-developers
> More help   : https://help.launchpad.net/ListHelp

Marko Mäkelä, Lead Developer InnoDB
MariaDB Corporation

Follow ups