maria-developers team mailing list archive

[Aleksey Midenkov <midenok@xxxxxxxxx>]

Hello!

Different semantics of these 2 members doesn't look good:

time_t start_time; /*!< time the state last time became
TRX_STATE_ACTIVE */
ib_uint64_t start_time_micro; /*!< start time of transaction in
microseconds */

Either `start_time_micro` should be drawn to the base of `start_time`
or it should be explicitly commented that it has nothing to do with
`start_time`. I.e. there is nothing wrong on algorithmic level, but
such data members may (and certainly would) lead developers to misuse
of `start_time_micro`.

-- 
All the best,

Aleksey Midenkov
@midenok