maria-developers team mailing list archive

[Jan Lindström <jan.lindstrom@xxxxxxxxxxx>]

Hi,

In my opinion there is already clear message about missing socat. Can we
add it as rpm requirement on 10.3 ?

R: Jan

On Tue, Feb 6, 2018 at 11:35 AM, Sergei Golubchik <serg@xxxxxxxxxxx> wrote:

> Hi, Jan!
>
> No, sorry, you cannot do it.
>
> First, we cannot add new RPM dependencies in GA (we tried once and had
> to revert that change).
>
> Second, there was already socat dependency in RPM, added by Nirbhay in
>
> MDEV-6211 MariaDB-Galera-server uses 'socat', but 'socat' is not in the
> dependency list
> commit bd5ca5e6093046d7e69cc59f0950a7af2c0a7bf2
>
> removed by Nirbhay in
>
> MDEV-7233: Fix issue with missing dependency socat when installing
> MariaDB-galera-server on RedhatEL/OracleEL/(Others?) RPM based
> commit 41367e4023d0823624a461597813e6902437f096
>
> I don't see a good solution for this issue. Adding socat to mariabackup
> package aren't much better, as mariabackup users don't really need socat
> either.
>
> May be just a better error message in the script?
>
> On Feb 06, jan wrote:
> > revision-id: 9bc03294c89b16df5f556b7d9fa4cb1eadae451a
> (mariadb-10.1.30-31-g9bc03294c89)
> > parent(s): 1cd1db9602476ec6864f4a521de97d788fe93fac
> > author: Jan Lindström
> > committer: Jan Lindström
> > timestamp: 2018-02-06 10:59:27 +0200
> > message:
> >
> > MDEV-15033: Node fails to join mdb cluster with wsrep_sst_mariabackup
> due to dependency from socat
> >
> > Add socat dependency to cpack_rpm.cmake. Similar dependency already
> > is on debian/control.
> >
> > diff --git a/cmake/cpack_rpm.cmake b/cmake/cpack_rpm.cmake
> > index e80fb199f03..5b9c6726b5e 100644
> > --- a/cmake/cpack_rpm.cmake
> > +++ b/cmake/cpack_rpm.cmake
> > @@ -170,7 +170,7 @@ SETA(CPACK_RPM_server_PACKAGE_REQUIRES
> >  IF(WITH_WSREP)
> >    SETA(CPACK_RPM_server_PACKAGE_REQUIRES
> >      "galera" "rsync" "lsof" "grep" "gawk" "iproute"
> > -    "coreutils" "findutils" "tar")
> > +    "coreutils" "findutils" "tar" "socat")
> >    IF (RPM MATCHES "sles11")
> >      SETA(CPACK_RPM_server_PACKAGE_REQUIRES "util-linux")
> >    ELSE()
>
> Regards,
> Sergei
> Chief Architect MariaDB
> and security@xxxxxxxxxxx
>