maria-developers team mailing list archive

Thread
Date

Re: [Commits] MDEV-15167 Server crashes in in bitmap_bits_set upon REPAIR PARTITION ...

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Sat, 10 Feb 2018 16:58:40 +0100
In-reply-to: <CAA4mGEQ-FXzbn4TsuRLYtVLtDTMkZ9f2++Ot=x84xpg0OMYWGw@mail.gmail.com>
User-agent: Mutt/1.7.2 (2016-11-26)

Hi, Sachin!

On Feb 09, Sachin Setiya wrote:
> commit 3e49ebcacf9022931f0dfefcb44c13973128f8c4
> Author: Sachin Setiya <sachinsetia1001@xxxxxxxxx>
> Date:   Fri Feb 9 17:44:04 2018 +0530
> 
>     MDEV-15167 Server crashes in in bitmap_bits_set upon REPAIR PARTITION
> ...
> 
> diff --git a/sql/sql_partition.cc b/sql/sql_partition.cc
> index a4d9406..3d53056 100644
> --- a/sql/sql_partition.cc
> +++ b/sql/sql_partition.cc
> @@ -4583,6 +4583,11 @@ uint prep_alter_part_table(THD *thd, TABLE *table,
> Alter_info *alter_info,
>         Alter_info::ALTER_TABLE_REORG |
>         Alter_info::ALTER_REBUILD_PARTITION))
>    {
> +    /*
> +      You can't add column when we are doing alter related to partition
> +    */
> +    DBUG_EXECUTE_IF("test_pseudo_invisible",{DBUG_ASSERT(0);});
> +    DBUG_EXECUTE_IF("test_completely_invisible",{DBUG_ASSERT(0);});

May be return error? Like with P_S?

  DBUG_EXECUTE_IF("test_pseudo_invisible", {DBUG_RETURN(1)});

but test it, may be you'll need my_error too, like

  DBUG_EXECUTE_IF("test_pseudo_invisible", {
    my_error(ER_INTERNAL_ERROR, MYF(0), "Don't to it with test_pseudo_invisible");
    DBUG_RETURN(1)
  });

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx