maria-developers team mailing list archive

[Marko Mäkelä <marko.makela@xxxxxxxxxxx>]

Hi Serge[yi]!

2018-07-04 11:17 GMT+03:00 Sergei Golubchik <serg@xxxxxxxxxxx>:
> Hi, Sergey!
>
> On Jul 03, Sergey Vojtovich wrote:
>> > > diff --git a/storage/tokudb/PerconaFT/portability/toku_crash.cc b/storage/tokudb/PerconaFT/portability/toku_crash.cc
>> > > index 0af85342a99..297cc29d9ca 100644
>> > > --- a/storage/tokudb/PerconaFT/portability/toku_crash.cc
>> > > +++ b/storage/tokudb/PerconaFT/portability/toku_crash.cc
>> > > @@ -70,7 +70,7 @@ run_gdb(pid_t parent_pid, const char *gdb_path) {
>> > >             "-ex", "thread apply all bt",
>> > >             "-ex", "thread apply all bt full",
>> > >             exe_buf, pid_buf,
>> > > -           NULL);
>> > > +           (char*) NULL);
>> >
>> > Why's that?
>> storage/tokudb/PerconaFT/portability/toku_crash.cc: In function ‘void run_gdb(pid_t, const char*)’:
>> storage/tokudb/PerconaFT/portability/toku_crash.cc:73:16: error: missing sentinel in function call [-Werror=format=]
>>             NULL);
>>                 ^
>
> interesting. ok.

Would using std::nullptr be a cleaner option?

Marko
-- 
Marko Mäkelä, Lead Developer InnoDB
MariaDB Corporation