← Back to team overview

maria-developers team mailing list archive

To MDEV-6608 Slave loses master binlog filename


Hello, Kristian.

I read through your analysis of the case to agree with
the plan and its motivation:

  MDEV-6608> Generally, it is a very bad idea to destroy data during
             crash recovery ...  try an approach that leaves the crashed
             binlog file intact, and instead ensures that the crashed
             binlog can be properly handled by the rest of the code.

So in case of a partially written event group (transaction)
the short (xid-less therefore) transaction is to be rolled back on the master.

So why won't we properly enclose the group in the binlog at the end of
recovery which means to append ROLLBACK Query-log-event, naturally before
that the last event of the group needs sanity check?

Was that that you had in mind actually?



Follow ups