maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Thirunarayanan!

On Nov 05, Thirunarayanan Balathandayuthapani wrote:
> revision-id: dc9f113111ee4daf3964db938ef3ddd82c777328 (mariadb-10.0.37-6-gdc9f113111e)
> parent(s): 38b3e52c3c40b35339b1d18c09053be416a93420
> author: Thirunarayanan Balathandayuthapani <thiru@xxxxxxxxxxx>
> committer: Thirunarayanan Balathandayuthapani <thiru@xxxxxxxxxxx>
> timestamp: 2018-11-01 21:24:03 +0530
> message:
> 
> MDEV-17376	Server fails to set ADD_PK_INDEX, DROP_PK_INDEX
> 		if unique index nominated as PK

Subject line in git commits is always one line. Try to prefer the format
as of

MDEV-17376 Server fails to set ADD_PK_INDEX, DROP_PK_INDEX if unique index nominated as PK

that is, MDEV-number, one space, MDEV summary verbatim, all on one line.
This way it'll look good in `git log --oneline` and one can search for a
bug description (and new lines won't cause the search to fail).

> - Server sets the flag ADD_PK_INDEX, DROP_PK_INDEX if the unique key
> nominated as Primary key.

this isn't a very helpful comment, just a rephrased commit title :)

Up to you, of course, it doesn't hurt. But generally, if you feel the
fix it kind of obvious and you cannot come up with anything to put into
commit comment body, just don't put there anything at all.

> 
> diff --git a/mysql-test/suite/innodb/t/alter_candidate_key.test b/mysql-test/suite/innodb/t/alter_candidate_key.test
> --- /dev/null
> +++ b/mysql-test/suite/innodb/t/alter_candidate_key.test
> @@ -0,0 +1,47 @@
> +--source include/have_innodb.inc
> +--source include/have_debug.inc
> +--source include/have_debug_sync.inc
> +
> +CREATE TABLE t1 (f1 INT NOT NULL, f2 INT NOT NULL,
> +  UNIQUE KEY uidx2(f1,f2),
> +  UNIQUE KEY uidx1(f2)
> +) ENGINE=InnoDB;
> +
> +SET DEBUG_SYNC = 'innodb_inplace_alter_table_enter SIGNAL conc_dml WAIT_FOR go_ahead';
> +INSERT INTO t1 VALUES(1,1);
> +--send
> +alter table t1 change column f1 f11 int, algorithm=inplace;
> +connect (con1,localhost,root,,);
> +SET DEBUG_SYNC = 'now WAIT_FOR conc_dml';
> +DELETE FROM t1;
> +SET DEBUG_SYNC = 'now SIGNAL go_ahead';
> +connection default;
> +reap;
> +CHECK TABLE t1;
> +DROP TABLE t1;

Could you explain the test case, please? What's going on here?
I don't understand what you're fixing and what I'm reviewing, sorry :(

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx