← Back to team overview

maria-developers team mailing list archive

Re: d282f5c5560: MDEV-10963 Fragmented BINLOG query



One correction to just sent reply,
in fact I've removed this:

>> --- a/sql/log_event.h
>> +++ b/sql/log_event.h
>> @@ -749,6 +749,7 @@ typedef struct st_print_event_info
>>      that was printed.  We cache these so that we don't have to print
>>      them if they are unchanged.
>>    */
>> +  static const uint max_delimiter_len= 16;
> why did you introduce this max_delimiter_len, if all you use
> is sizeof(delimiter) anyway? (and even that is not needed)

through following your simplification idea.