maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Varun!

Ok to push.
One comment below

On May 17, Varun Gupta wrote:
> revision-id: 82b6a5cb85f (mariadb-10.4.11-192-g82b6a5cb85f)
> parent(s): 3bfe305c5cd
> author: Varun Gupta <varun.gupta@xxxxxxxxxxx>
> committer: Varun Gupta <varun.gupta@xxxxxxxxxxx>
> timestamp: 2020-05-15 02:37:16 +0530
> message:
> 
> MDEV-22556: Incorrect result for window function when using encrypt-tmp-files=ON
> 
> diff --git a/mysql-test/suite/encryption/t/tempfiles_encrypted.opt b/mysql-test/suite/encryption/t/tempfiles_encrypted.opt
> new file mode 100644
> index 00000000000..f515f7b8689
> --- /dev/null
> +++ b/mysql-test/suite/encryption/t/tempfiles_encrypted.opt
> @@ -0,0 +1,5 @@
> +--encrypt-tmp_files=ON
> +--loose-file-key-management-encryption-algorithm=aes_cbc
> +--file-key-management=FORCE
> +--loose-file-key-management-filename=$MTR_SUITE_DIR/t/filekeys-data.enc
> +--loose-file-key-management-filekey=FILE:$MTR_SUITE_DIR/t/filekeys-data.key

this is very redundant, you include have_file_key_management_plugin.inc
and it already sets all options for the file_key_management plugin to work.

so you only need --encrypt-tmp_files=ON here.

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx