maria-developers team mailing list archive

[Aleksey Midenkov <midenok@xxxxxxxxx>]

Sergei,

On Tue, May 19, 2020 at 1:52 PM Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
>
> Hi, Aleksey!
>
> On May 19, Aleksey Midenkov wrote:
> > > > diff --git a/mysql-test/suite/versioning/engines.combinations b/mysql-test/suite/versioning/engines.combinations
> > > > index 26b5bab23f1..57e2af6cd06 100644
> > > > --- a/mysql-test/suite/versioning/engines.combinations
> > > > +++ b/mysql-test/suite/versioning/engines.combinations
> > > > @@ -7,5 +7,10 @@ default-storage-engine=innodb
> > > >  [myisam]
> > > >  default-storage-engine=myisam
> > > >
> > > > +[traditional]
> > > > +default-storage-engine=myisam
> > > > +sql-mode=traditional
> > >
> > > I'm not sure about it. It's, of course, safe to run all tests with every
> > > possible settings, but it really blows up testing times.
> > >
> > > May be it'd make sense to have a more targeted test here?
> >
> > Versioning suite without "traditional":
> >
> > real    0m32.805s
> > user    0m44.173s
> > sys     0m17.346s
> >
> > With "traditional":
> >
> > real    0m34.107s
> > user    0m50.038s
> > sys     0m20.001s
>
> what value of --parallel did you use? with --mem or without?

With --parallel=4; without --mem. Here are the numbers without both options:

real    2m19.709s
user    0m42.374s
sys     0m17.671s

real    2m21.355s
user    0m45.825s
sys     0m18.726s

>
> > IMO not much duration difference. OTOH testing everything with
> > sql-mode=traditional looks useful.
>
> Okay, as you like. It was just a suggestion, our test suite is quite
> slow as it is. But a couple of seconds is fine if they add enough value.
>
> > > >  [heap]
> > > >  default-storage-engine=memory
> > > > +
> > > > diff --git a/mysql-test/suite/versioning/r/select.result b/mysql-test/suite/versioning/r/select.result
> > > > index 3569268ce1d..68df246af6b 100644
> > > > --- a/mysql-test/suite/versioning/r/select.result
> > > > +++ b/mysql-test/suite/versioning/r/select.result
> > > > @@ -45,7 +45,7 @@ ASOF_x      y
> > > >  7    107
> > > >  8    108
> > > >  9    109
> > > > -select x as FROMTO_x, y from t1 for system_time from timestamp '0-0-0 0:0:0' to timestamp @t1;
> > > > +select x as FROMTO_x, y from t1 for system_time from timestamp '1970-01-01 00:00:00' to timestamp @t1;
> > >
> > > Does this test use a fixed time zone?
> >
> > Yes, this test uses fixed time zone +00:00 set in common.inc
>
> Sorry, missed that. I did look :(
>
> Regards,
> Sergei
> VP of MariaDB Server Engineering
> and security@xxxxxxxxxxx



-- 
All the best,

Aleksey Midenkov
@midenok