maria-developers team mailing list archive

[Sergey Petrunia <sergey@xxxxxxxxxxx>]

On Thu, Jun 11, 2020 at 03:41:24PM +0530, Varun Gupta wrote:
> >   /*
> >     pack_length() returns size (in bytes) used to store field data in
> > memory
> >     (i.e. it returns the maximum size of the field in a row of the table,
> >     which is located in RAM).
> >   */
> >   virtual uint32 pack_length() const { return (uint32) field_length; }
> >
> > so, it is size in bytes, while strnxfrmlen() accepts length *in
> > characters*.
> > That is, strnxfrmlen(field->pack_length()) is certainly not correct.
> >
> >
> This is not correct, strnxfrmlen accepts length in bytes and there we
> change the length to characters and then calculate the weights.

You're right. I've missed this part.

The patch is ok to push, then.

BR
 Sergei
-- 
Sergei Petrunia, Software Developer
MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog