← Back to team overview

maria-developers team mailing list archive

Re: 97f7d4a9b4d: MDEV-22726: Add check that one can't change general or slow log to a

 

Hi, Vlad!

On Jun 26, Vlad Lesin wrote:
> >>  
> >> +    if (create_info->db_type == maria_hton &&
> >> +        create_info->transactional != HA_CHOICE_NO)
> >> +    {
> >> +      my_error(ER_TRANSACTIONAL_ARIA_LOG_ENGINE, MYF(0));
> >> +      DBUG_RETURN(true);
> >> +    }
> > 
> > What about InnoDB? Or RocksDB? Or any other transactional engine?
> 
> There is flag HTON_SUPPORT_LOG_TABLES, which is checked earlier in
> mysql_alter_table().

It's not checked on CREATE, only on ALTER, so one can easily bypass this
check.

And, anyway, why an engine would not support log tables?
Only because it's transactional?

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx


References