← Back to team overview

maria-developers team mailing list archive

Re: ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

 

Hi, Sergei!

On Tue, Dec 1, 2020 at 7:54 PM Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
>
> Hi, Aleksey!
>
> On Nov 24, Aleksey Midenkov wrote:
> >
> > And mysqldump should take care of setting system_versioning_insert_history
> > sysvar. Right? Is everything else in the task description OK?
>
> Right.
>
> > 1. Add server variable system_versioning_insert_history which will allow
> > INSERT history rows.
> > 2. If secure_timestamp is YES or REPLICATION,
> > system_versioning_insert_history does not have effect. If secure_timestamp
> > is SUPER, system_versioning_insert_history requires special privilege (same
> > as for setting current timestamp).
>
> Yes. It is correct, but could be expressed simpler:
>
>   when @@system_versioning_insert_history=TRUE, one can directly insert
>   into row_start/row_end columns iff one can set @@timestamp variable.
>
> In other words, if one can create an arbitrary history by manipulating
> @@timestamp variable, @@system_versioning_insert_history allows to do it
> more conveniently. But if one cannot - he cannot.

Then do we need additional setting @@system_versioning_insert_history?
Iff one can manipulate history via @@timestamp variable let him set
row_start/row_end columns.

>
> Regards,
> Sergei
> VP of MariaDB Server Engineering
> and security@xxxxxxxxxxx


-- 
All the best,

Aleksey Midenkov
@midenok


Follow ups

References