maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Michael!

On Mar 29, Michael Widenius wrote:
> revision-id: 1d577194654 (mariadb-10.5.2-526-g1d577194654)
> parent(s): 1bbc852ef71
> author: Michael Widenius <michael.widenius@xxxxxxxxx>
> committer: Michael Widenius <michael.widenius@xxxxxxxxx>
> timestamp: 2021-03-24 15:03:04 +0200
> message:
> 
> Revert MDEV-16592 "Change Item::with_sum_func to a virtual method"
> 
> diff --git a/sql/item.cc b/sql/item.cc
> index e5be8699d80..e0ba4ff2c89 100644
> --- a/sql/item.cc
> +++ b/sql/item.cc
> @@ -975,9 +975,7 @@ class Item :public Value_source,
>    void share_name_with(const Item *item)
>    {
>      name= item->name;
> -    common_flags= static_cast<uint8>
> -     ((common_flags & ~IS_AUTO_GENERATED_NAME) |
> -      (item->common_flags & IS_AUTO_GENERATED_NAME));
> +    is_autogenerated_name= item->is_autogenerated_name;

this, apparently, should be in the commit 039f4a054bb
"Removed Item::common_flags and replaced it with bit fields"

>    }

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx