maria-developers team mailing list archive

[Michael Widenius <michael.widenius@xxxxxxxxx>]

Hi!

On Mon, Mar 29, 2021 at 4:20 PM Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
>
> Hi, Michael!

Only people who do not know me calls me Michael...
Who are you?

> > Revert MDEV-16592 "Change Item::with_sum_func to a virtual method"
> >
> > diff --git a/sql/item.cc b/sql/item.cc
> > index e5be8699d80..e0ba4ff2c89 100644
> > --- a/sql/item.cc
> > +++ b/sql/item.cc
> > @@ -975,9 +975,7 @@ class Item :public Value_source,
> >    void share_name_with(const Item *item)
> >    {
> >      name= item->name;
> > -    common_flags= static_cast<uint8>
> > -     ((common_flags & ~IS_AUTO_GENERATED_NAME) |
> > -      (item->common_flags & IS_AUTO_GENERATED_NAME));
> > +    is_autogenerated_name= item->is_autogenerated_name;
>
> this, apparently, should be in the commit 039f4a054bb
> "Removed Item::common_flags and replaced it with bit fields"

Have now done this.
I assume you understand that moving a commit like this between version
takes about 10-30 min and have no affect on the end result.

I am happy to do that if you think it is important, but doing it over
and over again
is a bit waste of time that I could use for more critical items...

Regards,
Monty