maria-developers team mailing list archive

Thread
Date

Re: f5196787294: MDEV-23178: Qualified asterisk not supported in INSERT .. RETURNING

To: Rucha Deodhar <rucha.deodhar@xxxxxxxxxxx>
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Thu, 22 Jul 2021 18:11:01 +0200
Cc: maria-developers@xxxxxxxxxxxxxxxxxxx
In-reply-to: <-VEGCWaekNK.A.8HE.maZ-gB@pweza>

Hi, Rucha!

ok to push!
thanks

On Jul 22, Rucha Deodhar wrote:
> revision-id: f5196787294 (mariadb-10.5.11-28-gf5196787294)
> parent(s): b1e57179242
> author: Rucha Deodhar
> committer: Rucha Deodhar
> timestamp: 2021-07-22 18:54:36 +0530
> message:
> 
> MDEV-23178: Qualified asterisk not supported in INSERT .. RETURNING
> 
> Analysis: When we have INSERT/REPLACE returning with qualified asterisk in the
> RETURNING clause, '*' is not resolved properly because of wrong context.
> context->table_list is NULL or has incorrect table because context->table_list
> has tables from the FROM clause. For INSERT/REPLACE...SELECT...RETURNING,
> context->table_list has table we are inserting from. While in other
> INSERT/REPLACE syntax, context->table_list is NULL because there is no FROM
> clause.
> Fix: If filling fields instead of '*' for qualified asterisk in RETURNING,
> use first_name_resolution_table for correct resolution of item.
> 
Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx