← Back to team overview

maria-developers team mailing list archive

Re: c4835af7e8c: MDEV-16026: Forbid global system_versioning_asof in non-default time zone

 

Hi, Nikita!

I suggest to squash commits from c4835af7e8c to 80e3007a5a1 into one.
It'll be simpler, no intermediate juggling with MYSQL_TIME anymore.

This squashed commit is ok to push (make sure to mention both MDEVs in
the commit comment, but not necessarily in the first line)

On Jul 26, Nikita Malyavin wrote:
> revision-id: c4835af7e8c (mariadb-10.3.30-30-gc4835af7e8c)
> parent(s): ec3289b6de4
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2021-07-21 00:21:31 +0300
> message:
> 
> MDEV-16026: Forbid global system_versioning_asof in non-default time zone
> 
> * store `system_versioning_asof` in unix time;
> * both session and global vars are processed in session timezone;
> * setting `default` does not copy global varibale abymore. Instead, it sets
>  system_time to SYSTEM_TIME_UNSPECIFIED, which means that no 'AS OF' time
>  is applied and `now()` can be assumed
> 
Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx