maria-developers team mailing list archive

Thread
Date

Re: a4a5c2d5963: MDEV-25908: -e does not work for my_print_defaults

To: Rucha Deodhar <rucha.deodhar@xxxxxxxxxxx>
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Mon, 26 Jul 2021 08:52:10 +0200
Cc: maria-developers@xxxxxxxxxxxxxxxxxxx
In-reply-to: <yQaA_HB4mrE.A.7AC.Znl_gB@pweza>

Hi, Rucha!

On Jul 26, Rucha Deodhar wrote:
> revision-id: a4a5c2d5963 (mariadb-10.5.11-52-ga4a5c2d5963)
> parent(s): 675b72d0da1
> author: Rucha Deodhar
> committer: Rucha Deodhar
> timestamp: 2021-07-23 19:51:57 +0530
> message:
> 
> MDEV-25908: -e does not work for my_print_defaults
> 
> Analysis: get_defaults_options() rewrites the value for my_defaults_file,
> my_defaults_extra_file and  my_defaults_group_suffix to 0. So the config file
> can't be read.
> Fix: Let handle_options() handle --defaults* option and create a new command
> line to pass it to load_defaults().
> 
> diff --git a/libmariadb b/libmariadb
> index 802ce584a26..180c543704d 160000
> --- a/libmariadb
> +++ b/libmariadb
> @@ -1 +1 @@
> -Subproject commit 802ce584a26fdc0ba67fcf35e277bf3c7440956a
> +Subproject commit 180c543704d627a50a52aaf60e24ca14e0ec4686

^^^^^
This is wrong, please, remove it from your commit

Otherwise ok to push

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx