maria-developers team mailing list archive

Thread
Date

Re: dcbdec60893: MDEV-26650: Failed ALTER USER/GRANT statement removes the password from the cache

To: Oleksandr Byelkin <sanja@xxxxxxxxxxx>
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Thu, 7 Oct 2021 18:57:08 +0200
Cc: maria-developers@xxxxxxxxxxxxxxxxxxx
In-reply-to: <Fq0YCD6DKZI.A.iRH.uUyXhB@pweza>

Hi, Oleksandr!

Ok to push!
A couple of typos below

On Oct 07, Oleksandr Byelkin wrote:
> revision-id: dcbdec60893 (mariadb-10.4.21-56-gdcbdec60893)
> parent(s): a75813d4673
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2021-10-07 11:39:02 +0200
> message:
> 
> MDEV-26650: Failed ALTER USER/GRANT statement removes the password from the cache
> 
> Starting from 10.4 AUTH is not part of ACL_USER so have to be safely copied.
> Patch made in line with preriouse code ideas.

"previous"

> diff --git a/sql/sql_acl.cc b/sql/sql_acl.cc
> index 0e2c044e3a1..cef51038540 100644
> --- a/sql/sql_acl.cc
> +++ b/sql/sql_acl.cc
> @@ -188,6 +188,9 @@ class ACL_USER_PARAM
>  class ACL_USER :public ACL_USER_BASE,
>                  public ACL_USER_PARAM
>  {
> +protected:
> +  // default shellow copy constructor (protect from non-authorized usage)

"shallow"

> +  ACL_USER(const ACL_USER &)= default;
>  public:

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx