← Back to team overview

maria-developers team mailing list archive

Re: Squash aaed3436 MENT-651 [4/8] ALTER ONLINE TABLE

 

Hi, Nikita!

I don't think it's a good idea. Old branches get deleted and
garbage-collected eventually. If you think the history is important for
understanding the changes - don't squash it. If you think it's not
important - you don't need a reference to the unsquashed branch :)

On Nov 25, Nikita Malyavin wrote:
> I mean, I'd just put the reference to the head in the commit message, i. e.
> now the last commit is
> 
>    - test progress reporting f1af51e4
> 
> I'd add a line:
> See unsquashed history at f1af51e4
> 
> In the final commit message
> 
> On Wed, 24 Nov 2021 at 23:50, Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
> 
> > Hi, Nikita!
> >
> > Sorry, I meant what did you mean by
> >
> > > I would also embed a reference to the original unsquashed branch.
> > > It seems to me as a good idea in sense of helping the reader
> > > investigate the code
> >
Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx


References