maria-developers team mailing list archive

[Sergey Petrunia <sergey@xxxxxxxxxxx>]

Hi Oleg,

> commit 92b85f455994ff9f18e30ad4b852109b3e3c5f04
> Author: Oleg Smirnov <olegs@xxxxxxxxxxx>
> Date:   Fri Dec 24 17:27:03 2021 +0300
> 
>     MDEV-27021 Implement SHOW ANALYZE command
> 

The patch looks good.  A few cosmetic comments below.

I've played with it and it looks usable, although I would expect that SHOW
ANALYZE FORMAT=JSON would be the real killer.

For SHOW ANALYZE FORMAT=JSON, I suspect we might need to add a few fields
into it to make analysis easier (I'll elaborate later).

Let's first get SHOW ANALYZE FORMAT=JSON to work without the extra columns.

== Cosmetic comments ==
Please make sure there are no spaces at line ends. Some MariaDB developers 
feel strongly about not having them. (If your edior doesn't highlight them,
"git citool" does).

At risk of stating the obvious:
* one should not remove the endspace if otherwise they are not changing the
line of code. (such "dummy" changes make it hard to look at the revision
history)
* If one adds a line or changes an existing line, make sure the line doesnt have
the end spaces.


> diff --git a/sql/share/errmsg-utf8.txt b/sql/share/errmsg-utf8.txt
> index f31f21faeb0..e18f8c61067 100644
> --- a/sql/share/errmsg-utf8.txt
> +++ b/sql/share/errmsg-utf8.txt
> @@ -7224,7 +7224,7 @@ ER_NO_SUCH_TABLE_IN_ENGINE 42S02
>          hindi "टेबल '%-.192s.%-.192s' इंजन में मौजूद नहीं है"
>          swe "Det finns ingen tabell som heter '%-.192s.%-.192s' i handlern"
>  ER_TARGET_NOT_EXPLAINABLE
> -        eng "Target is not running an EXPLAINable command"
> +        eng "Target is not running a command that allows to produce SHOW EXPLAIN or ANALYZE"
.
This will soon mean "SHOW EXPLAIN or ANALYZE or EXPLAIN FOR CONNECTION".

Does "Target is not executing an operation with a query plan" sound better?

>  ER_CONNECTION_ALREADY_EXISTS
>          eng "Connection '%.*s' conflicts with existing connection '%.*s'"
>  ER_MASTER_LOG_PREFIX

BR
 Sergei
-- 
Sergei Petrunia, Software Developer
MariaDB Corporation | Skype: sergefp | Blog: http://petrunia.net