maria-developers team mailing list archive

[Marko Mäkelä <marko.makela@xxxxxxxxxxx>]

Hi Otto,

git grep --recurse inconsistent-missing-destructor-override
tells me that the option is present in wsrep-lib/CMakeLists.txt and
had been added there about 2 months ago:
https://github.com/codership/wsrep-lib/commit/66a8fa9b13447b50f8b5e8bb8d25047355bddeef

The wsrep-lib submodule was updated a couple of weeks ago in the 10.4 branch, in
https://github.com/MariaDB/server/commit/c6ef9b1c1a59dd5dae81888d47f1749e1a433b96

I hope that this helps.

Marko

On Tue, May 16, 2023 at 9:20 AM Otto Kekäläinen <otto@xxxxxxxxxxxxxx> wrote:
>
> Hello!
>
> While working on
> https://salsa.debian.org/mariadb-team/mariadb-server/-/merge_requests/46
> (Import new upstream version 10.11.3 to Debian) I noticed that
> amd64->arm64 crossbuilding no longer works.
>
> The CI shows that Salsa-CI job `test-crossbuild-arm64` no longer
> passes. Based on Salsa-CI runs I can see that it [still worked in
> upstream commit
> e55e761e](https://salsa.debian.org/otto/mariadb-server/-/jobs/4217220)
> but [failed in upstream commit
> 06b443be](https://salsa.debian.org/otto/mariadb-server/-/jobs/4217664),
> thus some of these commits in between regressed it:
>
> ```
> 06b443be34e Nes CC 3.3
> 4a668c18926 MDEV-29401 InnoDB history list length increased in 10.6
> compared to 10.5
> f272463b028 Cleanup of MDEV-14974: --port ignored for --host=localhost
> bb1d1dc8465 Merge 10.5 into 10.6
> c5e50c48bba MDEV-30837: Remove usage of AWK in autobake-debs.sh
> f99a891858a MDEV-30837: Remove usage of AWK from Debian init and
> postinst scripts
> 5740638c4c3 MDEV-31132 Deadlock between DDL and purge of InnoDB history
> d4265fbde58 MDEV-26055: Correct the formula for adaptive flushing
> 898320b5f8a MDEV-30804 addendum for 10.6+ branches
> c22ab93f8af MDEV-26827 fixup: Prevent a hang in LRU eviction
> 818d5e48146 Merge 10.5 into 10.6
> 0976afec889 MDEV-31114 Assertion !...is_waiting() failed in
> os_aio_wait_until_no_pending_writes()
> 2c567b2fa37 MDEV-30996  insert.. select in presence of full text index
> freezes all other commits at commit time
> 51e62cb3b3b MDEV-26782 InnoDB temporary tablespace: reclaiming of free
> space does not work
> 204e7225dce Cleanup: MONITOR_EXISTING trx_undo_slots_used, trx_undo_slots_cached
> 86767bcc0f1 MDEV-29593 Purge misses a chance to free not-yet-reused undo pages
> 40eff3f8681 MDEV-26827 fixup: hangs and !os_aio_pending_writes()
> assertion failures
> ```
>
> Example of error in (cross)build log:
> ```
> Building CXX object CMakeFiles/cmTC_9b8d6.dir/src.cxx.o
> /usr/lib/ccache/c++ -DHAVE_INCONSISTENT_MISSING_DESTRUCTOR_OVERRIDE
> -g -O2 -ffile-prefix-map=/builds/otto/mariadb-server/debian/output/source_dir=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
> -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -pie -fPIC
> -fstack-protector --param=ssp-buffer-size=4 -Wall -Wextra
> -Woverloaded-virtual -Wconversion -g -Wsuggest-override
> -Winconsistent-missing-destructor-override -o
> CMakeFiles/cmTC_9b8d6.dir/src.cxx.o -c
> /builds/otto/mariadb-server/debian/output/source_dir/builddir-native/CMakeFiles/CMakeScratch/TryCompile-Nn98w6/src.cxx
> c++: error: unrecognized command-line option
> '-Winconsistent-missing-destructor-override'
> gmake[3]: *** [CMakeFiles/cmTC_9b8d6.dir/build.make:78:
> CMakeFiles/cmTC_9b8d6.dir/src.cxx.o] Error 1
> gmake[3]: Leaving directory
> '/builds/otto/mariadb-server/debian/output/source_dir/builddir-native/CMakeFiles/CMakeScratch/TryCompile-Nn98w6'
> gmake[2]: *** [Makefile:127: cmTC_9b8d6/fast] Error 2
> ```
>
> Is this enough information for somebody to guess what regressed?
>
> - Otto
>
> _______________________________________________
> Mailing list: https://launchpad.net/~maria-developers
> Post to     : maria-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~maria-developers
> More help   : https://help.launchpad.net/ListHelp



-- 
Marko Mäkelä, Lead Developer InnoDB
MariaDB plc