← Back to team overview

mudlet-makers team mailing list archive

[Bug 734741] [NEW] ctelnet.cpp decompression fails is compressed data sent with MCCP option

 

Public bug reported:

Mudlet 2.0-dev built: January 19, 2011
OS: kubuntu

in ctelnet.cpp  void cTelnet::handle_socket_signal_readyRead()


                                initStreamDecompressor();
                                pBuffer += 3;
                                //mWaitingForCompressedStreamToStart = false;
                                int restLength = datalen - i - 3;
                                if( restLength > 0 )
                                {
                                    datalen = decompressBuffer( pBuffer, restLength );
                                }
                                i = 0;

this has several errors that cause decompression errors.
think it needs to be

                                initStreamDecompressor();
                                pBuffer += i + 3;  
                                //mWaitingForCompressedStreamToStart = false;
                                int restLength = datalen - i -3;
                                if( restLength > 0 )
                                {
                                    datalen = decompressBuffer( pBuffer, restLength );
				     if(datalen !=-1)
				         datalen += i+3;
				}
                                i += 2;

** Affects: mudlet
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/734741

Title:
  ctelnet.cpp decompression fails is compressed data sent with MCCP
  option

Status in Mudlet the MUD client:
  New

Bug description:
  Mudlet 2.0-dev built: January 19, 2011
  OS: kubuntu

  in ctelnet.cpp  void cTelnet::handle_socket_signal_readyRead()

  
                                  initStreamDecompressor();
                                  pBuffer += 3;
                                  //mWaitingForCompressedStreamToStart = false;
                                  int restLength = datalen - i - 3;
                                  if( restLength > 0 )
                                  {
                                      datalen = decompressBuffer( pBuffer, restLength );
                                  }
                                  i = 0;

  this has several errors that cause decompression errors.
  think it needs to be

                                  initStreamDecompressor();
                                  pBuffer += i + 3;  
                                  //mWaitingForCompressedStreamToStart = false;
                                  int restLength = datalen - i -3;
                                  if( restLength > 0 )
                                  {
                                      datalen = decompressBuffer( pBuffer, restLength );
  				     if(datalen !=-1)
  				         datalen += i+3;
  				}
                                  i += 2;



Follow ups

References