← Back to team overview

mudlet-makers team mailing list archive

[Bug 1174484] [NEW] Loss of Area specificness inTArea::getRoomsByPosition()

 

Public bug reported:

Current (660) revision:

Whilst researching for other TLuaInterpreter methods that were subject
to the zero'th index problem mentioned in
https://bugs.launchpad.net/mudlet/+bug/1173407 I discovered that
TArea::getRoomsByPostion() was reporting rooms in ALL areas with the
supplied x,y,z coordinates whereas when it is utilised by
TLuaInterpreter::getRoomsByPostion() that method demands that it only
returns rooms at the given coordinates in the area implicit in the call
to the method.

I have attached a short patch that seems to fix this issue, however
because of the current state of my repository it might be a little fuzzy
around the line numbers - I tweaked them by hand to fit the current code
whereas I've dirtied my local copy a bit so I hope I got them right.

** Affects: mudlet
     Importance: Undecided
         Status: New

** Patch added: "Patch to restore Area selectivity to method"
   https://bugs.launchpad.net/bugs/1174484/+attachment/3659338/+files/TArea_getRoomsByPosition.patch

-- 
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/1174484

Title:
  Loss of Area specificness inTArea::getRoomsByPosition()

Status in Mudlet the MUD client:
  New

Bug description:
  Current (660) revision:

  Whilst researching for other TLuaInterpreter methods that were subject
  to the zero'th index problem mentioned in
  https://bugs.launchpad.net/mudlet/+bug/1173407 I discovered that
  TArea::getRoomsByPostion() was reporting rooms in ALL areas with the
  supplied x,y,z coordinates whereas when it is utilised by
  TLuaInterpreter::getRoomsByPostion() that method demands that it only
  returns rooms at the given coordinates in the area implicit in the
  call to the method.

  I have attached a short patch that seems to fix this issue, however
  because of the current state of my repository it might be a little
  fuzzy around the line numbers - I tweaked them by hand to fit the
  current code whereas I've dirtied my local copy a bit so I hope I got
  them right.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mudlet/+bug/1174484/+subscriptions


Follow ups

References