mudlet-makers team mailing list archive

[Stephen Lyons <1248806@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Current master Git version has bugs in the TArea::ausgaengeBestimmen() &
TArea::fast_ausgaengeBestimmen() code that stores the Id of the exit
FROM room where it should put the exit TO room in the TArea::exits data
structure.  The data created is stored in map files but is not currently
used, though that looks as if it could change in the future.  The only
user impact currently is some mildly confusing debug information on map
file loading.

At the same time as fixing this I noted that the exit directions are
encoded in a series of #defines that are incompatible with similar
values used elsewhere for the same purpose.  The attached patch unifies
the usage to remove this inconsistency but does invalidate the data held
in existing files - which will thus need to be discarded and regenerated
on loading old map files.  Current non-usage of this data and the ease
with which it can be remade from other data within the same map file
should make that a minor issue.

** Affects: mudlet
     Importance: Medium
     Assignee: Stephen Lyons (slysven)
         Status: New

** Patch added: "Patch to current code to correct bug."
   https://bugs.launchpad.net/bugs/1248806/+attachment/3902035/+files/commit-b1ae516

-- 
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/1248806

Title:
  fast_ & ausgaengeBestimmen() don't store TO roomID

Status in Mudlet the MUD client:
  New

Bug description:
  Current master Git version has bugs in the TArea::ausgaengeBestimmen()
  & TArea::fast_ausgaengeBestimmen() code that stores the Id of the exit
  FROM room where it should put the exit TO room in the TArea::exits
  data structure.  The data created is stored in map files but is not
  currently used, though that looks as if it could change in the future.
  The only user impact currently is some mildly confusing debug
  information on map file loading.

  At the same time as fixing this I noted that the exit directions are
  encoded in a series of #defines that are incompatible with similar
  values used elsewhere for the same purpose.  The attached patch
  unifies the usage to remove this inconsistency but does invalidate the
  data held in existing files - which will thus need to be discarded and
  regenerated on loading old map files.  Current non-usage of this data
  and the ease with which it can be remade from other data within the
  same map file should make that a minor issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mudlet/+bug/1248806/+subscriptions