mugle-dev team mailing list archive

[Scott Ritchie <s.ritchie73@xxxxxxxxx>]

I have no idea, i just copied what was existing in the ServiceImpl that
Prageeth wrote,
I assumed they were set up correctly - Youre right, it doesnt make sense,
its not properly checking,
Prageeth must have just copied it through all the methods as a placeholder.

On Mon, May 23, 2011 at 11:49 AM, Matt Giuca <matt.giuca@xxxxxxxxx> wrote:

> Thanks Scott, for the tip to look in GameFileServiceImpl.checkPermissions.
>
> One thing I don't understand (and possibly a bug), what is this code doing:
>
>         ClientView cv = (curUser.getPrimaryKey() == object.getPrimaryKey())
> ?
>                 ClientView.PRIVATE : ClientView.PUBLIC;
>
> I don't know what a ClientView is exactly. But this code makes no sense...
> why is it checking if the current user's primary key is equal to the
> GameFile's primary key? Surely those keys will never be equal, and therefore
> the view will always be public?
>
> --
> Mailing list: https://launchpad.net/~mugle-dev
> Post to     : mugle-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~mugle-dev
> More help   : https://help.launchpad.net/ListHelp
>
>