← Back to team overview

multi-touch-dev team mailing list archive

Re: Policy on formatting fixes intermixed with code changes?


On 03/26/2012 06:51 PM, Peter Hutterer wrote:
> In that case, I strongly recommend separate commits unless the whitespace
> can be fixed by that commit directly (i.e. the actual fix is in the same
> line). whitespace patches are a no-brainer to review. If you fix misc
> whitespace issues within another commit and you then have to revert that
> commit, future patches that build on those unrelated hunks may have merge
> conflicts. The only exception here is if they are in the same natural hunk
> (i.e. the whitespace change doesn't make the hunk [significantly?] larger)


Stephen M. Webb  <stephen.webb@xxxxxxxxxxxxx>
Canonical Ltd.