← Back to team overview

mylvmbackup-discuss team mailing list archive

Re: patches for backuptype=none and error handling


Hi Kjetil,

Happy New Year to you! Sorry for the late reply - I've been on
vacation and tried to stay away from
the PC as much as I could ;)

On Mon, Dec 27, 2010 at 12:10, Kjetil Torgrim Homme
<kjetil.homme@xxxxxxxxxxxxxxxxxx> wrote:

> this was not sufficient, I've seen instances where $HOME is defined, but
> set to "/" rather than "/root".  a better patch would be to add the
> following:
> $ENV{PATH} .= ":/usr/sbin:/usr/bin:/sbin:/bin";
> if (!defined $ENV{HOME} || $ENV{HOME} eq "/") {
>  $ENV{HOME} = (getpwuid($<))[7];
> }
> this will still allow a sysadmin to use a custom $HOME for the process.

Excellent, thanks! I've applied your patch and the followup, the code
is now included in the following
branch: https://code.launchpad.net/~lenzgr/mylvmbackup/mylvmbackup-fixes-kjetil

I will perform some tests and revise the documentation, then your
changes will be merged into the
trunk so they are part of the next release. Thanks a lot for you contribution!

 Lenz Grimmer <lenz@xxxxxxxxxxx> -  http://www.lenzg.net/