mysql-proxy-discuss team mailing list archive

[Jan Kneschke <jan@xxxxxxxxxxx>]

Hi,

Kay please review

  https://code.launchpad.net/~jan-kneschke/mysql-proxy/api-cleanup

It cleans up the naming of a few API calls (network_socket_init() ->
network_socket_new()) and reduces the warning count to a few off_t-based
printf() warnings and a few unused static functions.

On the API cleanup:

With this patch-set we now should follow the glib conventions of:

  _init() takes a structure and initializes it
  _new() allocates and initializes it

Like g_thread_init() which initializes the thread-subsystem. We have
something similar in our plugin interface:

  plugin = chassis_plugin_new();

  ... in the plugin ...
  proxy_plugin_init(plugin);

  chassis_plugin_free(plugin);



cheers,
  Jan
-- 
 jan: "Gee, Brain^WEric, what'd you wanna do tonight?"
eric: Same thing we do everynight: Take over the HelloWorld!