← Back to team overview

nagios-charmers team mailing list archive

Re: [Merge] ~aluria/hw-health-charm/+git/hw-health-charm:bug/1832387 into hw-health-charm:master

 

Hey Ryan, with the clarifications made above, this should be testable since 2019-06-27. I've taken notes from Andrew on documentation improvements that I will do once the code review is also completed. Such recommendations are:
1) src/... has the README but Makefile is one level up (a future bug will move src/* into the top level, but the initial version of template-python-pytest was structured with src/, which is the folder pushed to the charmstore; hence, needs the README there)

2) Document check_ipmi git submodule (needs to be cloned at least once for testing)

3) Document the need of an lxd controller for the hw-health-charm to be tested. Other juju providers won't work because the functional tests expect a container on the first test - or the unit won't get blocked when "manufacturer=auto".

Please let me know if I can help you more. Thank you.
-- 
https://code.launchpad.net/~aluria/hw-health-charm/+git/hw-health-charm/+merge/369278
Your team Nagios Charm developers is subscribed to branch hw-health-charm:master.


References