← Back to team overview

nagios-charmers team mailing list archive

Re: [Merge] ~aluria/hw-health-charm/+git/hw-health-charm:bug/1832387 into hw-health-charm:master

 

* Functional tests: 10 passed, 2 warnings in 757.66 seconds (warnings due to charmhelpers lib)
* Unit tests: Ran 21 tests in 0.039s (unmodified, since this bug verification is done via functional tests)
* pep8: commands succeeded (flake8 --max-complexity=20 --max-line-length=120 .)

TODO: complete functional tests to test adding a correct tools.zip that matches whitelisted checksums. I'm not sure if units trigger the "upgrade-charm" hook, since that is the current way of clearing the "hw-health.unsupported" flag set when checksum verification fails (I did it this way to avoid trying to install all tools every 5 minutes in response to the update-status hook).
-- 
https://code.launchpad.net/~aluria/hw-health-charm/+git/hw-health-charm/+merge/369278
Your team Nagios Charm developers is subscribed to branch hw-health-charm:master.


Follow ups