nagios-charmers team mailing list archive

[Felipe Reyes <felipe.reyes@xxxxxxxxxxxxx>]

The proposal to merge ~freyes/thruk-agent-charm:lp1829681 into thruk-agent-charm:master has been updated.

Description changed to:

Without my patch this is the output of update-status hook:
$  juju run --unit thruk-agent/0 ./hooks/update-status
Hit:1 http://ppa.launchpad.net/canonical-bootstack/thruk/ubuntu bionic InRelease
Hit:2 http://nova.clouds.archive.ubuntu.com/ubuntu bionic InRelease
Hit:3 http://security.ubuntu.com/ubuntu bionic-security InRelease
Hit:4 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-updates InRelease
Hit:5 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-backports InRelease
Reading package lists...
Executing: /tmp/apt-key-gpghome.WZwE7x9axn/gpg.1.sh --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 7A207542
Hit:1 http://security.ubuntu.com/ubuntu bionic-security InRelease
Hit:2 http://nova.clouds.archive.ubuntu.com/ubuntu bionic InRelease
Hit:3 http://ppa.launchpad.net/canonical-bootstack/thruk/ubuntu bionic InRelease
Hit:4 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-updates InRelease
Hit:5 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-backports InRelease
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
pwgen is already the newest version (2.08-1).
apache2-utils is already the newest version (2.4.29-1ubuntu4.11).
thruk is already the newest version (2.24-2ubuntu6).
The following package was automatically installed and is no longer required:
  grub-pc-bin
Use 'apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
active
inactive
Warning: apt-key output should not be parsed (stdout is not a terminal)
gpg: key 4B9A81747A207542: "Launchpad PPA for Canonical Bootstack" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1


With my patch this is the output:

$  juju run --unit thruk-agent/0 ./hooks/update-status
active
inactive


This is because add-apt-repository, apt-get update and apt-get install are only executed when needed.

For more details, see:
https://code.launchpad.net/~freyes/thruk-agent-charm/+git/thruk-agent-charm/+merge/376486
-- 
Your team Nagios Charm developers is requested to review the proposed merge of ~freyes/thruk-agent-charm:lp1829681 into thruk-agent-charm:master.