← Back to team overview

nagios-charmers team mailing list archive

Re: [Merge] ~freyes/thruk-agent-charm:lp1829681 into thruk-agent-charm:master

 

ubuntu@juju-fe68f7-foo-0:~$ wc -l /etc/apt/sources.list.d/canonical-bootstack-ubuntu-thruk-bionic.list
3 /etc/apt/sources.list.d/canonical-bootstack-ubuntu-thruk-bionic.list
ubuntu@juju-fe68f7-foo-0:~$ cat /etc/apt/sources.list.d/canonical-bootstack-ubuntu-thruk-bionic.list
deb http://ppa.launchpad.net/canonical-bootstack/thruk/ubuntu bionic main
# deb-src http://ppa.launchpad.net/canonical-bootstack/thruk/ubuntu bionic main
# deb-src http://ppa.launchpad.net/canonical-bootstack/thruk/ubuntu bionic main


^ this is the content of *.list file, as can be seen there are 2 deb-src which exposes that add-apt-repository was called twice, this should be because the first config.previous() returns None and on the subsequent hooks returns "ppa:...", if this is not good enough, I can spend a few more cycles to avoid this double call.
-- 
https://code.launchpad.net/~freyes/thruk-agent-charm/+git/thruk-agent-charm/+merge/376486
Your team Nagios Charm developers is requested to review the proposed merge of ~freyes/thruk-agent-charm:lp1829681 into thruk-agent-charm:master.


References